Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical #2

Closed
Solido opened this issue Jul 22, 2018 · 4 comments
Closed

Vertical #2

Solido opened this issue Jul 22, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Solido
Copy link

Solido commented Jul 22, 2018

I guess one word is enough to describe the idea ;)
This is not a requirement but better have it in mind since designers will come with it one day or another.

@letsar
Copy link
Owner

letsar commented Jul 22, 2018

For now we can slide to the left or to the right, and if I understand, this feature would be to allow the item to slide to the top or to the bottom?
If it's the case, it would interfere with the scroll, wouldn't it?

@Solido
Copy link
Author

Solido commented Jul 22, 2018

This library is based on the concept of dismissible which mainly is found on vertical list.

You slide horizontal when the List is vertical
You may have to slide vertical when the list is horizontal aka PageView

Imagine a PageView of Images, you can slide UP to display more control items under the bottom of image. Since it's horizontal you can have more options.

@letsar
Copy link
Owner

letsar commented Jul 22, 2018

Oh yes you're right, I completely missed it!
If I follow, the Dismissible API. Slidable should have actionDelegate instead of leftActionDelegate and secondaryDelegate instead of rightActionDelegate.
I will work on it today, since this will not be backward compatible at all.

Thanks for having pointed this out!

@letsar letsar self-assigned this Jul 22, 2018
@letsar letsar added the enhancement New feature or request label Jul 22, 2018
This was referenced Jul 22, 2018
@letsar letsar closed this as completed in #5 Jul 22, 2018
@letsar
Copy link
Owner

letsar commented Jul 22, 2018

Available on version 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants