Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete treshold is not respected if move quickly #230

Closed
vytautas-pranskunas- opened this issue Jul 22, 2021 · 12 comments
Closed

Delete treshold is not respected if move quickly #230

vytautas-pranskunas- opened this issue Jul 22, 2021 · 12 comments

Comments

@vytautas-pranskunas-
Copy link

Version: 1.0.0-dev.6

Screen.Recording.2021-07-22.at.18.36.03.mov

described here: #223

@letsar
Copy link
Owner

letsar commented Jul 23, 2021

I cannot reproduce. Can you share some code?

@vytautas-pranskunas-
Copy link
Author

Sure

new Slidable(
      key: Key(notification.id),
      endActionPane: ActionPane(
        motion: const DrawerMotion(),
        extentRatio: 0.25,
        dismissible: DismissiblePane(
          onDismissed: () => _controller.onSwipeDetelete(notification.id, index),
          closeOnCancel: true,
        ),
        children: [
          SlidableAction(
            icon: Icons.delete,
            backgroundColor: CustomColors.imperialRed,
            onPressed: (context) {},
          ),
        ],
      ),
      child: notificationView,

@letsar
Copy link
Owner

letsar commented Jul 24, 2021

Can you send me a complete sample I would just have to run to reproduce the issue?

@vytautas-pranskunas-
Copy link
Author

I cannot because its big peace :) but you see it in video :(

@letsar
Copy link
Owner

letsar commented Jul 24, 2021

Can't you make a basic code sample that reproduce the issue? Sorry but without something to reproduce it, I can't fix it.

@vytautas-pranskunas-
Copy link
Author

I understand how it works. But to make reproducable example it might take long because not sure what cuases it.
This" #229 might be impacted by MobX but empty clicks should not efeect that.
This, what you see in video, it basically empty code as I gave you. There is nothing more.... It is not reproducable every time. Just try to play with it... Move it slowly long way, then couple of times faster but not long way... I really was not doing anything speciall, I just migrated the code to latest version and noticed that after few attempts to delete.

If neither works - maybe after app release (aprox 2-4 weeks) I will try to do reprodcuable code :) but please try first

@letsar
Copy link
Owner

letsar commented Jul 24, 2021

I've just published a fix for an animation issue. Did it also resolve your issue? (1.0.0-dev.8)

@vytautas-pranskunas-
Copy link
Author

vytautas-pranskunas- commented Jul 25, 2021

I will check. Have you been able to reproduce it?
Animation you men this issue or #229?

@letsar
Copy link
Owner

letsar commented Jul 25, 2021

No I didn't really reproduced this issue nor the 229, but maybe it resolved what you experienced.

@vytautas-pranskunas-
Copy link
Author

Yes it is fixed now.

@marcio-ota
Copy link

The problem persist on 1.1.0
When SlidableAction is opened and move, a little bit, quickly

@buvtopcc
Copy link

buvtopcc commented Jan 31, 2023

I encountered the same problem on 2.0.0 , through the modification of the source code to [solve。
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants