Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong division getMinChildIndexForScrollOffset #232

Closed
NktnSmn opened this issue Feb 8, 2022 · 2 comments
Closed

Wrong division getMinChildIndexForScrollOffset #232

NktnSmn opened this issue Feb 8, 2022 · 2 comments

Comments

@NktnSmn
Copy link

NktnSmn commented Feb 8, 2022

Hello!
I have found a problem. You may catch it if you use SliverQuiltedGridDelegate's crossAxisCount with value 2 and one QuiltedGridTile(2, 2).
The reason is in wrong division - getMinChildIndexForScrollOffset. It may be fixed with division by pattern.mainAxisCellCount like in getMaxChildIndexForScrollOffset. Please correct me if I’m wrong.

getMinChildIndexForScrollOffset.mp4
@letsar
Copy link
Owner

letsar commented Jul 10, 2022

Yes, I think you're right, I'll fix that, thanks a lot!

This was referenced Jul 10, 2022
Closed
Closed
@letsar letsar closed this as completed in 9c82ca2 Jul 10, 2022
@letsar
Copy link
Owner

letsar commented Jul 10, 2022

Fixed in 0.6.2. Thanks again for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@letsar @NktnSmn