Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollable.ensureVisible(context) broken due to incorrect childScrollOffset() #59

Open
spkersten opened this issue Mar 29, 2021 · 1 comment · May be fixed by #60
Open

Scrollable.ensureVisible(context) broken due to incorrect childScrollOffset() #59

spkersten opened this issue Mar 29, 2021 · 1 comment · May be fixed by #60
Labels
waiting for user response

Comments

@spkersten
Copy link

spkersten commented Mar 29, 2021 •
edited
Loading

When using Scrollable.ensureVisible(context) on a child of SliverStickyHeader with overlapsContent: true, the Scrollable scrolls to the wrong position.

The problem appears to be in childScrollOffset (https://github.com/letsar/flutter_sticky_header/blob/master/lib/src/rendering/sliver_sticky_header.dart#L346) which returns _headerExtent even with overlapping headers. I think that should be headerLogicalExtent (= overlapsContent ? 0.0 : _headerExtent).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting for user response
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix childScrollOffset when the header overlaps the child spkersten/flutter_sticky_header
2 participants
@spkersten @letsar