Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis integration may expose integration keys #237

Closed
vlm opened this issue Dec 7, 2015 · 6 comments
Closed

Travis integration may expose integration keys #237

vlm opened this issue Dec 7, 2015 · 6 comments

Comments

@vlm
Copy link

vlm commented Dec 7, 2015

screen shot 2015-12-06 at 11 58 44 pm

Suggested change: hide the GH_TOKEN environment varibable from being exposed by potential git push failure (network related or some temporary github glitch will cause such failures), according to this instruction:

http://stackoverflow.com/questions/18027115/committing-via-travis-ci-failing

@martinthomson
Copy link
Contributor

You can configure Circle CI to use an authorized SSH key that will never suffer from this problem, or use a simpler solution, such as this: https://github.com/martinthomson/i-d-template/blob/master/ghpages.mk#L67-L68 You lose the output, so the answer on stackoverflow is more elegant, but it works well enough.

@vlm
Copy link
Author

vlm commented Dec 7, 2015

@martinthomson the "such as this" part seems to suffer from the same key exposure problem.

@martinthomson
Copy link
Contributor

@vlm, how so? Echoing the line is suppressed and all output is directed to /dev/null.

@vlm
Copy link
Author

vlm commented Dec 7, 2015

@martinthomson ah, you are correct. Didn't notice the 2>&1.

@martinthomson
Copy link
Contributor

Incidentally, I tried the solution that is described in the stack overflow answer. It works great for Travis and locally. However, I also support Circle CI, and it fails miserably there. I haven't figured out how to override how credentials are selected. I tried tricking it in several different ways, but it seems like the SSH key circle uses takes precedence. It looks like the output suppression is going to stay :(

@cpu
Copy link
Contributor

cpu commented Apr 4, 2017

This repository is deprecated & un-maintained. Closing this issue. If applicable, please move discussion to the replacement IETF owned repo and the mailing list.

@cpu cpu closed this as completed Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants