Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash commands and hiding minimap button lead to error #4

Closed
Nercus opened this issue Dec 26, 2020 · 9 comments · Fixed by #12
Closed

Slash commands and hiding minimap button lead to error #4

Nercus opened this issue Dec 26, 2020 · 9 comments · Fixed by #12

Comments

@Nercus
Copy link

Nercus commented Dec 26, 2020

By either using the Slash commands /mdt or /manbabydungeontools or going into the options to hide the minimap button leads to following error:

2x ...eManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua:1042: bad argument #1 to 'random' (interval is empty)
[string "=[C]"]: in function `random'
[string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:1042: in function `UpdateBottomText'
[string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:676: in function `ShowInterface'
[string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:32: in function `OnClick'
[string "@BigWigs\Libs\LibDBIcon-1.0\LibDBIcon-1.0-44.lua"]:144: in function <BigWigs\Libs\LibDBIcon-1.0\LibDBIcon-1.0.lua:142>

Locals:
(*temporary) = 0

Edit: Clicking on the minimap button leads to same error (opens the window though)

@T3ll1nG
Copy link

T3ll1nG commented Dec 26, 2020

The same error is also thrown when using the minimap button.

@mmpashby
Copy link
Contributor

mmpashby commented Dec 26, 2020

this should fix the issue.

@T3ll1nG
Copy link

T3ll1nG commented Dec 26, 2020

It didn't fix it for me.

@mmpashby
Copy link
Contributor

@T3ll1nG Can you provide the error you get please? This fix did work for me on testing.

@T3ll1nG
Copy link

T3ll1nG commented Dec 26, 2020

@Pashbee
You suggested changing line 570 in MDT/Locales/enUS

I run Win10 en-US and the gameclient is en-US too.

I get the same error message as before.

If you click the minimap button:
2x ...eManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua:1042: bad argument #1 to 'random' (interval is empty)
[string "=[C]"]: in function random' [string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:1042: in function UpdateBottomText'
[string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:676: in function ShowInterface' [string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:32: in function OnClick'
[string "@BigWigs\Libs\LibDBIcon-1.0\LibDBIcon-1.0-44.lua"]:144: in function <BigWigs\Libs\LibDBIcon-1.0\LibDBIcon-1.0.lua:142>

Locals:
(*temporary) = 0

If you use /mdt or /manbabydungeontools after wiping saved bugs
1x ...eManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua:1042: bad argument #1 to 'random' (interval is empty)
[string "=[C]"]: in function random' [string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:1042: in function UpdateBottomText'
[string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:676: in function ShowInterface' [string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:62: in function ?'
[string "@FrameXML\ChatFrame.lua"]:5093: in function ChatEdit_ParseText' [string "@FrameXML\ChatFrame.lua"]:4757: in function ChatEdit_SendText'
[string "@FrameXML\ChatFrame.lua"]:4793: in function <FrameXML\ChatFrame.lua:4789>
[string "=[C]"]: in function `ChatEdit_OnEnterPressed'
[string ":OnEnterPressed"]:1: in function <[string ":OnEnterPressed"]:1>

Locals:
(*temporary) = 0

@mmpashby
Copy link
Contributor

the PR got merged but you're right it does not work because of case sensitivity on the lookup. I am sorry. I will fix and put a PR in again.

@mmpashby
Copy link
Contributor

@T3ll1nG fix here - I could re-produce the error you were seeing. Please let me know if that works.

@T3ll1nG
Copy link

T3ll1nG commented Dec 26, 2020

@Pashbee that fix works just fine.
Nice 👍

@lexaprofessional
Copy link

@Pashbee i had the same issue but your fix + changing the casing worked for me as well

This was referenced Dec 26, 2020
srenauld pushed a commit that referenced this issue Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants