Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue with minutes instead of displaying hours after 59:59 #29

Closed
maximus1127 opened this issue Nov 29, 2021 · 7 comments
Closed

Continue with minutes instead of displaying hours after 59:59 #29

maximus1127 opened this issue Nov 29, 2021 · 7 comments
Assignees

Comments

@maximus1127
Copy link

Hi, is there a way to continue counting up in minutes instead of transitioning from 59:59 to 01:00:00. In this example, it would start counting up to 60:00 and then a minute later 61:00 etc...

@letstri letstri self-assigned this Mar 25, 2022
@letstri
Copy link
Owner

letstri commented Mar 25, 2022

Hi, I'll update the lib. I want to add calculations only for existing DOM elements in timer.

@maximus1127
Copy link
Author

oh what glorious news!!! This will add that little extra sauce to my project. Greatly appreciated.

@letstri
Copy link
Owner

letstri commented Mar 28, 2022

@maximus1127 Done.

@letstri letstri closed this as completed Mar 28, 2022
@maximus1127
Copy link
Author

wonderful! what's the parameter to activate this new feature?

@letstri
Copy link
Owner

letstri commented Mar 28, 2022

@maximus1127 you can remove not needed data attributes, in your case I think this variant will be correct:

<div class="j-timer">
  <span data-minutes></span>
  <span data-seconds></span>
</div>

@maximus1127
Copy link
Author

image

Hmm, i swapped out the code in my project for the latest file in your dist folder and removed my hours html element and got this error in the console. Did I do that upgrade process correctly?

@letstri
Copy link
Owner

letstri commented Mar 28, 2022

I changed selectors to HTML Element, you need to initialize with document.querySelector, or something like that. Read documentation for more info)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants