Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update peer dependencies #2

Open
cbotmk3 opened this issue Feb 7, 2024 · 2 comments
Open

Please update peer dependencies #2

cbotmk3 opened this issue Feb 7, 2024 · 2 comments

Comments

@cbotmk3
Copy link

cbotmk3 commented Feb 7, 2024

We've been using this script-loader alongside Angular 15 and so far had no problems.
When installing for the first time, we get the following errors:

npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @letterflow/ngx-dynamic-script-loader@0.0.2
npm ERR! Found: @angular/common@15.2.9
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"^15.2.9" from the root project
npm ERR!   peer @angular/common@"^15.0.0 || ^16.0.0" from @angular/cdk@15.2.9
npm ERR!   node_modules/@angular/cdk
npm ERR!     @angular/cdk@"^15.2.9" from the root project
npm ERR!   7 more (@angular/forms, @angular/platform-browser, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^14.0.0" from @letterflow/ngx-dynamic-script-loader@0.0.2
npm ERR! node_modules/@letterflow/ngx-dynamic-script-loader
npm ERR!   @letterflow/ngx-dynamic-script-loader@"0.0.2" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @angular/common@14.3.0
npm ERR! node_modules/@angular/common
npm ERR!   peer @angular/common@"^14.0.0" from @letterflow/ngx-dynamic-script-loader@0.0.2
npm ERR!   node_modules/@letterflow/ngx-dynamic-script-loader
npm ERR!     @letterflow/ngx-dynamic-script-loader@"0.0.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Seems like peerDeps requires Angular 14:

  "peerDependencies": {
    "@angular/common": "^14.0.0",
    "@angular/core": "^14.0.0",
[...]

Could you please update the peer dependencies to support newer Angular versions?

@ekkolon
Copy link
Contributor

ekkolon commented Feb 10, 2024

Hey, thanks for pointing this out.

I'll take a look at this. But Angular changed a lot since, so I don't know the scope of changes needed for this update - so it may take some time.

@cbotmk3
Copy link
Author

cbotmk3 commented Feb 12, 2024

Okay, thanks! At least Angular 15 runs without problems, we've been testing this at least half a year now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants