Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate reactive StreamChannel methods #1434

Closed
mp911de opened this issue Sep 29, 2020 · 0 comments
Closed

Deprecate reactive StreamChannel methods #1434

mp911de opened this issue Sep 29, 2020 · 0 comments
Labels
type: breaking Breaking change type: task A general task
Milestone
6.0.0

Comments

@mp911de
Copy link
Collaborator

mp911de commented Sep 29, 2020

We should deprecate all StreamChannel methods on the reactive API as this pattern is discouraged in favor of directly streaming commands through the resulting Publisher. Methods such as hmget should return directly Flux<KeyValue<K, V>> instead of Mono<Map<K, V>> to enable streaming capabilities.
@mp911de mp911de added type: task A general task type: breaking Breaking change labels Sep 29, 2020
@mp911de mp911de added this to the 6.0.0 milestone Sep 29, 2020
@mp911de mp911de mentioned this issue Sep 29, 2020
Closed
mp911de added a commit that referenced this issue Sep 29, 2020
@mp911de
Change hgetall return type from Mono<Map> to Flux<KeyValue> #1434
52ae9c0 
Enable streaming of the hash key value pairs.
mp911de added a commit that referenced this issue Sep 29, 2020
@mp911de
Polishing #1434
5fc9d3f 
Update generated Javadoc.
mp911de added a commit that referenced this issue Sep 29, 2020
@mp911de
Deprecate reactive StreamChannel methods #1434
8a4a321 
Reactive methods accepting a StreamChannel argument are now deprecated in favor of using the variant returning Flux<T> to consume large results using streaming. All methods that are likely to return large results (e.g. hgetall) are stream-enabled and there's no need to use a stream bridge that would work like an aggregator or collector. Using Publisher is idiomatic in reactive programming arrangements.

Async and sync methods accepting StreamChannel remain untouched and can be used for result streaming if the application follows asynchronous or imperative programming models.
@mp911de mp911de closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: breaking Breaking change type: task A general task
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
1 participant
@mp911de