Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ZMSCORE key member [member ...] command #1449

Closed
mp911de opened this issue Oct 8, 2020 · 0 comments
Closed

Add support for ZMSCORE key member [member ...] command #1449

mp911de opened this issue Oct 8, 2020 · 0 comments
Labels
type: enhancement A general enhancement
Milestone
6.1 M1

Comments

@mp911de
Copy link
Collaborator

mp911de commented Oct 8, 2020

https://redis.io/commands/zmscore
@mp911de mp911de added this to the 6.1 M1 milestone Oct 8, 2020
@mp911de mp911de added the status: help-wanted An issue that a contributor can help us with label Oct 8, 2020
@dengliming dengliming mentioned this issue Oct 10, 2020
Closed
4 tasks
@mp911de mp911de added type: enhancement A general enhancement and removed status: help-wanted An issue that a contributor can help us with labels Oct 26, 2020
mp911de pushed a commit that referenced this issue Oct 26, 2020
@dengliming @mp911de
Add support for ZMSCORE key member [member ...] command #1449
c4c3c40
mp911de added a commit that referenced this issue Oct 26, 2020
@mp911de
Polishing #1452 #1449
b379599 
Add since tags. Order methods alphabetically. Add zmscore to Coroutines API

Remove StreamingOutput from DoubleListOutput to preserve null elements in List<Double> as ZMSCORE returns (nil) for elements that weren't found and ReactivePublisher emits every list item individually. Since null values are not allowed in Reactive Streams, we need to collect all scores first and then emit the List.

Pin return type of ZMSCORE to List<Double> for the Reactive API.

Guard tests so they don't fail on older Redis versions. Adapt tests.

Original pull request: #1456.
mp911de pushed a commit that referenced this issue Oct 26, 2020
@dengliming @mp911de
Add support for ZMSCORE key member [member ...] command #1449
e001acc 
Original pull request: #1456.
mp911de added a commit that referenced this issue Oct 26, 2020
@mp911de
Polishing #1452 #1449
3a3fd7e 
Add since tags. Order methods alphabetically. Add zmscore to Coroutines API

Remove StreamingOutput from DoubleListOutput to preserve null elements in List<Double> as ZMSCORE returns (nil) for elements that weren't found and ReactivePublisher emits every list item individually. Since null values are not allowed in Reactive Streams, we need to collect all scores first and then emit the List.

Pin return type of ZMSCORE to List<Double> for the Reactive API.

Guard tests so they don't fail on older Redis versions. Adapt tests.

Original pull request: #1456.
@mp911de mp911de closed this as completed Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
6.1 M1
Development

Successfully merging a pull request may close this issue.

Add support for ZMSCORE、SMISMEMBER command dengliming/lettuce-core
1 participant
@mp911de