Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or replace ClusterRule #1478

Closed
mp911de opened this issue Oct 26, 2020 · 0 comments
Closed

Remove or replace ClusterRule #1478

mp911de opened this issue Oct 26, 2020 · 0 comments
Labels
type: task A general task
Milestone
6.0.2

Comments

@mp911de
Copy link
Collaborator

mp911de commented Oct 26, 2020

To entirely remove JUnit 4, we need to rework tests using ClusterRule. Ideally, we extract code from the rule into some utilities since the rule mainly issues a flushall on all nodes (Lettuce can do that already through the standard connection interface).
@sokomishalov sokomishalov mentioned this issue Nov 1, 2020
Closed
@mp911de mp911de added the type: task A general task label Nov 2, 2020
mp911de pushed a commit that referenced this issue Nov 2, 2020
@sokomishalov @mp911de
Replace JUnit 4 code and remove JUnit 4 entirely #1478
8c5ecbd 
Original pull request: #1487.
mp911de added a commit that referenced this issue Nov 2, 2020
@mp911de
Polishing #1478
e0aefae 
Update Javadoc. Add author tags. Remove JUnit leftovers. Exclude JUnit from TestNG depdendency and replace multithreadedtc with series of CountDownLatch. Replace leftover assertNotNull with AssertJ.

Upgrade to TestNG 7.3.0 to re-enable RedisPublisherVerification.

Original pull request: #1487.
mp911de pushed a commit that referenced this issue Nov 2, 2020
@sokomishalov @mp911de
Replace JUnit 4 code and remove JUnit 4 entirely #1478
44cd44a 
Original pull request: #1487.
mp911de added a commit that referenced this issue Nov 2, 2020
@mp911de
Polishing #1478
a836f68 
Update Javadoc. Add author tags. Remove JUnit leftovers. Exclude JUnit from TestNG depdendency and replace multithreadedtc with series of CountDownLatch. Replace leftover assertNotNull with AssertJ.

Upgrade to TestNG 7.3.0 to re-enable RedisPublisherVerification.

Original pull request: #1487.
@mp911de mp911de added this to the 6.0.2 milestone Nov 2, 2020
@mp911de mp911de closed this as completed Nov 2, 2020
sokomishalov added a commit to sokomishalov/lettuce that referenced this issue Nov 4, 2020
@sokomishalov
Replace JUnit 4 code and remove JUnit 4 entirely redis#1478
2166a0c 
Original pull request: redis#1487.
sokomishalov pushed a commit to sokomishalov/lettuce that referenced this issue Nov 4, 2020
@mp911de @sokomishalov
Polishing redis#1478
c39bfbe 
Update Javadoc. Add author tags. Remove JUnit leftovers. Exclude JUnit from TestNG depdendency and replace multithreadedtc with series of CountDownLatch. Replace leftover assertNotNull with AssertJ.

Upgrade to TestNG 7.3.0 to re-enable RedisPublisherVerification.

Original pull request: redis#1487.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
6.0.2
Development

No branches or pull requests
1 participant
@mp911de