Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LettuceStrings does not handle -nan which is returned by FT.INFO in redisearch #1482

Closed
krm1312 opened this issue Oct 29, 2020 · 1 comment
Closed

LettuceStrings does not handle -nan which is returned by FT.INFO in redisearch #1482

krm1312 opened this issue Oct 29, 2020 · 1 comment
Labels
type: bug A general bug
Milestone
5.3.6

Comments

@krm1312
Copy link
Contributor

krm1312 commented Oct 29, 2020

Opened in LettuceSearch project here RediSearch/lettusearch#33, but, fix will need to be made in lettuce-core and then they can delete their copy (which has no other changes as far I can tell).

FT.INFO info command can/does return "-nan" for at least one double (avarage_cycle_time_ms). This causes a NumberFormatException.

44)  1) "bytes_collected"
     2) "0"
     3) "total_ms_run"
     4) "0"
     5) "total_cycles"
     6) "0"
     7) "avarage_cycle_time_ms"
     8) "-nan"
     9) "last_run_time_ms"
    10) "0"
    11) "gc_numeric_trees_missed"
    12) "0"
    13) "gc_blocks_denied"
    14) "0"

That project appears to have patched (and copied!) LettuceStrings to address this but that is not a workable solution since it relies on classpath ordering among other reasons.

PR shortly.
@krm1312 krm1312 added the type: bug A general bug label Oct 29, 2020
@krm1312 krm1312 mentioned this issue Oct 29, 2020
Closed
@mp911de mp911de added this to the 5.3.6 milestone Oct 30, 2020
krm1312 pushed a commit to krm1312/lettuce-core that referenced this issue Oct 30, 2020
Handle NaN in LettuceStrings.toDouble redis#1482
a9f322a 
At least redis search can return '-nan' in some fieds from ft.info.
krm1312 pushed a commit to krm1312/lettuce-core that referenced this issue Oct 30, 2020
@krm1312
Handle NaN in LettuceStrings.toDouble redis#1482
562d64d 
At least redis search can return '-nan' in some fieds from ft.info.
dengliming pushed a commit that referenced this issue Oct 31, 2020
@dengliming
Handle NaN in LettuceStrings.toDouble #1482
3b7f21d 
Original pull request: #1483.
dengliming pushed a commit that referenced this issue Oct 31, 2020
@dengliming
Handle NaN in LettuceStrings.toDouble #1482
5cc285a 
Original pull request: #1483.
dengliming pushed a commit that referenced this issue Oct 31, 2020
@dengliming
Handle NaN in LettuceStrings.toDouble #1482
a23af1f 
Original pull request: #1483.
@dengliming
Copy link
Collaborator

Closed by #1483 and Thanks to @krm1312

sokomishalov pushed a commit to sokomishalov/lettuce that referenced this issue Nov 4, 2020
@sokomishalov
Handle NaN in LettuceStrings.toDouble redis#1482
6a078ce 
Original pull request: redis#1483.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
5.3.6
Development

No branches or pull requests
3 participants
@krm1312 @mp911de @dengliming