Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support NOMKSTREAM option in xadd command #1502

Closed
mp911de opened this issue Nov 7, 2020 · 0 comments
Closed

Support NOMKSTREAM option in xadd command #1502

mp911de opened this issue Nov 7, 2020 · 0 comments
Assignees
@dengliming
Labels
type: enhancement A general enhancement
Milestone
6.1 M1

Comments

@mp911de
Copy link
Collaborator

mp911de commented Nov 7, 2020

See redis/redis#7910, we should add that option to XAddArgs.
@mp911de mp911de added the type: enhancement A general enhancement label Nov 7, 2020
@dengliming dengliming self-assigned this Nov 8, 2020
@dengliming dengliming mentioned this issue Nov 8, 2020
Closed
4 tasks
mp911de pushed a commit that referenced this issue Nov 8, 2020
@dengliming @mp911de
Support NOMKSTREAM option in xadd command #1502
1a1e0be 
Original pull request: #1504.
mp911de added a commit that referenced this issue Nov 8, 2020
@mp911de
Polishing #1502
7410f5d 
Consistently use lowercase for nomkstream to align with XGroupCreateArgs.

Introduce nomkstream() factory method. Tweak Javadoc, simplify tests.

Original pull request: #1504.
@mp911de mp911de added this to the 6.1 M1 milestone Nov 8, 2020
@mp911de mp911de closed this as completed Nov 8, 2020
sokomishalov pushed a commit to sokomishalov/lettuce that referenced this issue Nov 11, 2020
@dengliming @sokomishalov
Support NOMKSTREAM option in xadd command redis#1502
541fb81 
Original pull request: redis#1504.
sokomishalov pushed a commit to sokomishalov/lettuce that referenced this issue Nov 11, 2020
@mp911de @sokomishalov
Polishing redis#1502
772aa90 
Consistently use lowercase for nomkstream to align with XGroupCreateArgs.

Introduce nomkstream() factory method. Tweak Javadoc, simplify tests.

Original pull request: redis#1504.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dengliming dengliming

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
6.1 M1
Development

Successfully merging a pull request may close this issue.

Support NOMKSTREAM option in xadd command dengliming/lettuce-core
2 participants
@mp911de @dengliming