Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend CommandDetailParser to include ACL details #1503

Closed
mp911de opened this issue Nov 7, 2020 · 3 comments
Closed

Extend CommandDetailParser to include ACL details #1503

mp911de opened this issue Nov 7, 2020 · 3 comments
Labels
status: help-wanted An issue that a contributor can help us with type: enhancement A general enhancement
Milestone

Comments

@mp911de
Copy link
Collaborator

mp911de commented Nov 7, 2020

We should pick up ACL details if available through CommandDetailParser

@mp911de mp911de added type: enhancement A general enhancement status: help-wanted An issue that a contributor can help us with labels Nov 7, 2020
@sokomishalov
Copy link
Collaborator

I am not clear with this a bit - how exactly we should pick up ACL details and how it is related to command details?

@mp911de
Copy link
Collaborator Author

mp911de commented Nov 30, 2020

The output of COMMAND has changed between Redis 5 and 6. In Redis 6.

Redis 5:

127.0.0.1:6379> command info set
1) 1) "set"
   2) (integer) -3
   3) 1) write
      2) denyoom
   4) (integer) 1
   5) (integer) 1
   6) (integer) 1

Redis 6 (element 7 was added):

127.0.0.1:6379> command info set
1) 1) "set"
   2) (integer) -3
   3) 1) write
      2) denyoom
   4) (integer) 1
   5) (integer) 1
   6) (integer) 1
   7) 1) @write
      2) @string
      3) @slow

sokomishalov added a commit to sokomishalov/lettuce that referenced this issue Nov 30, 2020
sokomishalov added a commit to sokomishalov/lettuce that referenced this issue Nov 30, 2020
@sokomishalov
Copy link
Collaborator

sokomishalov commented Nov 30, 2020

Oops, haven't noticed this change.
Official docs for command are not updated yet with ACL-related stuff so it confused me.
Thanks, I got it now.
Related PR: #1539

@mp911de mp911de added this to the 6.1 M1 milestone Dec 15, 2020
sokomishalov added a commit to sokomishalov/lettuce that referenced this issue Dec 24, 2020
mp911de pushed a commit that referenced this issue Jan 8, 2021
mp911de added a commit that referenced this issue Jan 8, 2021
Add author and since tags.

Original pull request: #1539.
@mp911de mp911de closed this as completed Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help-wanted An issue that a contributor can help us with type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants