-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use pause detector for CommandLatencyCollector
by default
#1995
Labels
type: enhancement
A general enhancement
Milestone
Comments
Thanks a lot for the detailed investigation. Would you like to submit a pull request to switch to |
sinrimin
added a commit
to sinrimin/lettuce-core
that referenced
this issue
Feb 11, 2022
mp911de
added
type: enhancement
A general enhancement
and removed
type: task
A general task
labels
Feb 25, 2022
mp911de
changed the title
Pause Detection does not work as expected
Do not use pause detector for Feb 25, 2022
CommandLatencyCollector
by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
I found that
DefaultCommandLatencyCollector
usesLatencyUtils.SimplePauseDetector
by default, butSimplePauseDetector
doesn't work as expected when pause occurs. Please try the test code below.Test Code
Expected behavior/code
Possible Solution
Do not use
SimplePauseDetector
by default.The micrometer has a similar problem, and since
1.0.10
,1.1.4
, and1.2.0
has usedNoPauseDetector
by default.Pause Detection contributes to count when it should just contribute to total time.
The text was updated successfully, but these errors were encountered: