Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect should create new handler instances #317

Closed
mp911de opened this issue Jul 23, 2016 · 0 comments
Closed

Reconnect should create new handler instances #317

mp911de opened this issue Jul 23, 2016 · 0 comments
Labels
type: enhancement A general enhancement

Comments

@mp911de
Copy link
Collaborator

mp911de commented Jul 23, 2016

Reconnection retains handler instances. This leads sometimes to issues like #315 that two channels are bound to one CommandHandler. Reconnection should create a new set of instances and transfer the state from the old handler to the new one. Ideally, the state is held outside the handler.

@mp911de mp911de added this to the Lettuce 5.0.0 milestone Jul 23, 2016
mp911de added a commit that referenced this issue Sep 3, 2016
Refactoring of CommandHandler and connection handling. Lettuce now uses the Endpoint concept to represent communication with a server. Endpoints may be in a connected or disconnected state and are used by the stateful connection. Channel handlers are no longer reused but registered per channel pipeline. Each CommandHandler has its own queue instance to keep track of alive command processing. Command buffering (disconnected endpoint) is held on endpoint level.

The stateful connection is no longer required to be a command handler but can be notified from endpoints (see PubSubEndpoint).
@mp911de mp911de added the type: enhancement A general enhancement label Sep 3, 2016
@mp911de mp911de closed this as completed Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant