Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChannelInitializer (PING before connect) waits indefinite #470

Closed
mp911de opened this issue Feb 15, 2017 · 0 comments
Closed

ChannelInitializer (PING before connect) waits indefinite #470

mp911de opened this issue Feb 15, 2017 · 0 comments
Labels
type: bug A general bug
Milestone

Comments

@mp911de
Copy link
Collaborator

mp911de commented Feb 15, 2017

PlainChannelInitializer and SslChannelInitializer have no timeout processing for the ping command that may run forever when the remote side is unresponsive.

@mp911de mp911de added the type: bug A general bug label Feb 15, 2017
@mp911de mp911de added this to the Lettuce 4.4.0 milestone Feb 20, 2017
mp911de added a commit that referenced this issue Feb 20, 2017
PING before activate connection now applies the configured command timeout from RedisURI to guard connection initialization. Applying the timeout monitors the PING command (AUTH for connections using a password). If the timeout is reached, the initialization future is completed with a timeout exception which closed the connection. If the PING is completed in time, command monitoring is canceled.
mp911de added a commit that referenced this issue Feb 20, 2017
PING before activate connection now applies the configured command timeout from RedisURI to guard connection initialization. Applying the timeout monitors the PING command (AUTH for connections using a password). If the timeout is reached, the initialization future is completed with a timeout exception which closed the connection. If the PING is completed in time, command monitoring is canceled.
mp911de added a commit that referenced this issue Feb 20, 2017
PING before activate connection now applies the configured command timeout from RedisURI to guard connection initialization. Applying the timeout monitors the PING command (AUTH for connections using a password). If the timeout is reached, the initialization future is completed with a timeout exception which closed the connection. If the PING is completed in time, command monitoring is canceled.
@mp911de mp911de closed this as completed Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant