Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RedisClient.shutdown() does not synchronize on clientResources.shutdown future #475

Closed
mp911de opened this issue Feb 23, 2017 · 0 comments
Closed

RedisClient.shutdown() does not synchronize on clientResources.shutdown future #475

mp911de opened this issue Feb 23, 2017 · 0 comments
Labels
type: bug A general bug
Milestone
Lettuce 4.3.2

Comments

@mp911de
Copy link
Collaborator

mp911de commented Feb 23, 2017

Client shutdown triggers ClientResources shutdown but does not reuse the future to synchronize shutdown.
@mp911de mp911de added the type: bug A general bug label Feb 23, 2017
mp911de added a commit that referenced this issue Mar 14, 2017
@mp911de
Synchronize ClientResources shutdown in client shutdown #475
d00f767 
Synchronize on the ClientResources.close()-Future when shutting down a redis client instance via AbstractRedisClient.shutdown(…). Previously the close future was not used to synchronize shutdown which might leave running threads after leaving AbstractRedisClient.shutdown(…).

Client shutdown may take longer because of synchronization. The client may be shut down faster by calling the appropriate shutdown method with the desired timeout/quiet period.
mp911de added a commit that referenced this issue Mar 14, 2017
@mp911de
Synchronize ClientResources shutdown in client shutdown #475
7ff4c0b 
Synchronize on the ClientResources.close()-Future when shutting down a redis client instance via AbstractRedisClient.shutdown(…). Previously the close future was not used to synchronize shutdown which might leave running threads after leaving AbstractRedisClient.shutdown(…).

Client shutdown may take longer because of synchronization. The client may be shut down faster by calling the appropriate shutdown method with the desired timeout/quiet period.
mp911de added a commit that referenced this issue Mar 14, 2017
@mp911de
Synchronize ClientResources shutdown in client shutdown #475
5444004 
Synchronize on the ClientResources.close()-Future when shutting down a redis client instance via AbstractRedisClient.shutdown(…). Previously the close future was not used to synchronize shutdown which might leave running threads after leaving AbstractRedisClient.shutdown(…).

Client shutdown may take longer because of synchronization. The client may be shut down faster by calling the appropriate shutdown method with the desired timeout/quiet period.
@mp911de mp911de added this to the Lettuce 4.3.2 milestone Mar 14, 2017
@mp911de mp911de closed this as completed Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
Lettuce 4.3.2
Development

No branches or pull requests
1 participant
@mp911de