Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultClientResources: fix typos #1497

Merged
merged 1 commit into from
Nov 6, 2020
Merged

DefaultClientResources: fix typos #1497

merged 1 commit into from
Nov 6, 2020

Conversation

perlun
Copy link
Contributor

@perlun perlun commented Nov 6, 2020

(Sorry to hear about your phone @mp911de, hope you managed to sort it out somehow.)

Discovered while using this class, seems like a pretty straight-forward thing to fix to me so here goes. Thanks for a great Redis client. 馃檹

Copy link
Collaborator

@dengliming dengliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mp911de mp911de added the type: documentation A documentation update label Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #1497 into main will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1497      +/-   ##
============================================
+ Coverage     78.77%   78.81%   +0.03%     
- Complexity     6225     6229       +4     
============================================
  Files           462      462              
  Lines         20790    20790              
  Branches       2300     2300              
============================================
+ Hits          16378    16386       +8     
+ Misses         3347     3344       -3     
+ Partials       1065     1060       -5     
Impacted Files Coverage 螖 Complexity 螖
.../lettuce/core/resource/DefaultClientResources.java 91.01% <0.00%> (酶) 36.00 <0.00> (酶)
.../io/lettuce/core/protocol/ReconnectionHandler.java 75.67% <0.00%> (-4.06%) 21.00% <0.00%> (-1.00%)
.../java/io/lettuce/core/protocol/CommandHandler.java 75.38% <0.00%> (+1.79%) 113.00% <0.00%> (+4.00%)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 80.39% <0.00%> (+2.61%) 39.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update fe70d44...fc23311. Read the comment docs.

@dengliming dengliming merged commit 8011d5c into redis:main Nov 6, 2020
@perlun perlun deleted the patch-2 branch November 7, 2020 06:24
sokomishalov pushed a commit to sokomishalov/lettuce that referenced this pull request Nov 11, 2020
Fix typos in DefaultClientResources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants