Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout parameter for nanoseconds in RedisURI #1528

Closed
wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Nov 24, 2020

This PR fixes timeout parameter for nanoseconds in RedisURI.

@mp911de mp911de self-requested a review November 24, 2020 08:00
@mp911de mp911de added the type: bug A general bug label Nov 24, 2020
@mp911de mp911de added this to the 5.3.6 milestone Nov 24, 2020
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #1528 (1f2173b) into main (137aa14) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1528      +/-   ##
============================================
+ Coverage     78.89%   78.94%   +0.04%     
- Complexity     6295     6298       +3     
============================================
  Files           470      470              
  Lines         21028    21028              
  Branches       2315     2315              
============================================
+ Hits          16590    16600      +10     
+ Misses         3375     3369       -6     
+ Partials       1063     1059       -4     
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/lettuce/core/RedisURI.java 92.37% <100.00%> (ø) 154.00 <0.00> (ø)
.../io/lettuce/core/protocol/ReconnectionHandler.java 75.67% <0.00%> (-4.06%) 21.00% <0.00%> (-1.00%)
.../io/lettuce/core/protocol/CommandExpiryWriter.java 73.07% <0.00%> (-3.85%) 15.00% <0.00%> (-2.00%)
...ce/core/masterreplica/SentinelTopologyRefresh.java 84.96% <0.00%> (-0.66%) 35.00% <0.00%> (ø%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 86.95% <0.00%> (ø) 1.00% <0.00%> (ø%)
...java/io/lettuce/core/protocol/DefaultEndpoint.java 70.06% <0.00%> (+0.46%) 99.00% <0.00%> (ø%)
...core/cluster/ClusterDistributionChannelWriter.java 79.00% <0.00%> (+0.50%) 57.00% <0.00%> (+1.00%)
.../java/io/lettuce/core/protocol/CommandHandler.java 75.63% <0.00%> (+2.03%) 114.00% <0.00%> (+4.00%)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 81.04% <0.00%> (+3.26%) 39.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 137aa14...1f2173b. Read the comment docs.

@mp911de mp911de modified the milestones: 5.3.6, 6.0.2 Nov 27, 2020
mp911de added a commit that referenced this pull request Nov 27, 2020
Add unit test to verify nanoseconds in the connection URL
mp911de added a commit that referenced this pull request Nov 27, 2020
Add unit test to verify nanoseconds in the connection URL
@mp911de
Copy link
Collaborator

mp911de commented Nov 27, 2020

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Nov 27, 2020
@izeye izeye deleted the timeout branch November 27, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants