Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential null-dereference in CommandHandler #1703

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

wbzj1110
Copy link
Contributor

@wbzj1110 wbzj1110 commented Apr 2, 2021

resolve #1701

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

just added a non-empty judgment

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #1703 (160f9ab) into 5.3.x (ba6e81c) will increase coverage by 0.01%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              5.3.x    #1703      +/-   ##
============================================
+ Coverage     79.71%   79.72%   +0.01%     
- Complexity     5892     5899       +7     
============================================
  Files           423      423              
  Lines         19679    19682       +3     
  Branches       2232     2234       +2     
============================================
+ Hits          15687    15692       +5     
  Misses         2949     2949              
+ Partials       1043     1041       -2     
Impacted Files Coverage Δ Complexity Δ
.../java/io/lettuce/core/protocol/CommandHandler.java 76.64% <40.00%> (-0.61%) 103.00 <0.00> (ø)
...io/lettuce/core/masterslave/SentinelConnector.java 65.00% <0.00%> (-17.50%) 6.00% <0.00%> (-2.00%)
...tuce/core/masterslave/SentinelTopologyRefresh.java 84.96% <0.00%> (-1.31%) 35.00% <0.00%> (ø%)
src/main/java/io/lettuce/core/ScanStream.java 86.53% <0.00%> (-1.29%) 24.00% <0.00%> (ø%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 88.26% <0.00%> (+0.86%) 1.00% <0.00%> (ø%)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 80.89% <0.00%> (+4.45%) 42.00% <0.00%> (+4.00%)
.../io/lettuce/core/protocol/ReconnectionHandler.java 72.89% <0.00%> (+6.54%) 26.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6e81c...160f9ab. Read the comment docs.

@wbzj1110
Copy link
Contributor Author

wbzj1110 commented Apr 2, 2021

I just just added a non-empty judgment ,and I don't know why

codecov/patch — 40.00% of diff hit (target 79.71%)

these happened?(`・ω・´)

@wbzj1110 wbzj1110 closed this Apr 2, 2021
@wbzj1110 wbzj1110 reopened this Apr 2, 2021
@mp911de mp911de added the type: bug A general bug label Apr 7, 2021
@mp911de mp911de merged commit af60f59 into redis:5.3.x Apr 7, 2021
@mp911de mp911de changed the title fix infinate print null point exception for trace bug #1701 Fix potential null-dereference in CommandHandler Apr 7, 2021
@mp911de mp911de added this to the 5.3.7 milestone Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants