Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kotlin api generator to provide replacement for a deprecated method #1759

Closed
wants to merge 1 commit into from

Conversation

sokomishalov
Copy link
Collaborator

@sokomishalov sokomishalov commented May 29, 2021

  • minor typo fix.

@sokomishalov sokomishalov changed the title bump kotlin and kotlinx-coroutines to 1.5.*, improve kotlin api gener… Improve kotlin api generator to provide replacement for a deprecated method May 29, 2021
@codecov
Copy link

codecov bot commented May 29, 2021

Codecov Report

Merging #1759 (0eda3b1) into main (31f8635) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 0eda3b1 differs from pull request most recent head 0514b24. Consider uploading reports for the commit 0514b24 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1759   +/-   ##
=========================================
  Coverage     78.26%   78.27%           
  Complexity     6731     6731           
=========================================
  Files           508      508           
  Lines         22682    22682           
  Branches       2465     2465           
=========================================
+ Hits          17752    17754    +2     
+ Misses         3781     3780    -1     
+ Partials       1149     1148    -1     
Impacted Files Coverage Δ
...o/lettuce/core/event/command/CommandBaseEvent.java 53.84% <0.00%> (-46.16%) ⬇️
.../io/lettuce/core/protocol/CommandExpiryWriter.java 75.00% <0.00%> (-1.93%) ⬇️
...main/java/io/lettuce/core/AbstractRedisClient.java 77.17% <0.00%> (-0.55%) ⬇️
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 87.39% <0.00%> (+1.73%) ⬆️
...a/io/lettuce/core/pubsub/PubSubCommandHandler.java 89.28% <0.00%> (+2.67%) ⬆️
.../io/lettuce/core/protocol/ReconnectionHandler.java 79.72% <0.00%> (+4.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31f8635...0514b24. Read the comment docs.

@mp911de mp911de added this to the 6.2.0 milestone Jun 21, 2021
@mp911de mp911de added the type: task A general task label Jun 21, 2021
pom.xml Outdated Show resolved Hide resolved
@mp911de mp911de modified the milestones: 6.2.0, 6.1.5 Sep 3, 2021
mp911de pushed a commit that referenced this pull request Sep 3, 2021
mp911de pushed a commit that referenced this pull request Sep 3, 2021
@mp911de
Copy link
Collaborator

mp911de commented Sep 3, 2021

Thank you for your contribution. That's merged and backported now.

@mp911de mp911de closed this Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants