Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run flush commands with FlushMode on upstreams only #1908

Closed

Conversation

schnapster
Copy link
Contributor

Ahoy, some of the flush commands are executed on all nodes of a cluster, but should only run on upstreams. This PR adds tests and code changes to address that. I noticed this while working on a solution for spring-projects/spring-data-redis#2187

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@mp911de mp911de self-assigned this Nov 8, 2021
@mp911de mp911de added type: enhancement A general enhancement type: bug A general bug and removed type: enhancement A general enhancement labels Nov 8, 2021
@mp911de mp911de modified the milestones: 6.0.9, 6.1.6 Dec 3, 2021
@mp911de mp911de changed the title Run flush commands on upstreams only Run flush commands with FlushMode on upstreams only Dec 3, 2021
mp911de added a commit that referenced this pull request Dec 3, 2021
Run flushall/flushdb using FlushMode on upstream nodes only.
mp911de added a commit that referenced this pull request Dec 3, 2021
Run flushall/flushdb using FlushMode on upstream nodes only.
@mp911de
Copy link
Collaborator

mp911de commented Dec 3, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Dec 3, 2021
@schnapster schnapster deleted the fix-flush-commands-on-clusters branch December 3, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants