Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent API changes broke the code #3

Open
echelon opened this issue Dec 7, 2023 · 2 comments
Open

Recent API changes broke the code #3

echelon opened this issue Dec 7, 2023 · 2 comments

Comments

@echelon
Copy link

echelon commented Dec 7, 2023

Hi @leunamcrack ! I think we broke your library when we moved the job queue onto a new token format. We emulated the old API, but your code does validation against the token prefixes. We'll need to modify your code to treat the tokens as opaque strings and it should work.

@mchernoff
Copy link

mchernoff commented Dec 19, 2023

The issue is with the "job" regex in Constants.js

Changing it to /^(?:JT?INF[:_](?:[a-z0-9]){26,27})$/i fixed the issue for me. Not sure if this is the best regex for the most recent FakeYou token format, but it works.

Would make a PR for this if I had permission.

@samikool
Copy link

samikool commented Apr 2, 2024

I created a pull request #4 that uses @mchernoff's constant and fixes the issue.

I'm not sure how long if it will take a while to get merged or not, so I may upload a forked package to npm in the meantime. So for anyone coming here check out my fork if this repo if the change hasn't been merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants