Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do with the 'leveldb' package in npm #54

Closed
rvagg opened this issue Apr 21, 2014 · 5 comments
Closed

What to do with the 'leveldb' package in npm #54

rvagg opened this issue Apr 21, 2014 · 5 comments
Labels
discussion Discussion

Comments

@rvagg
Copy link
Member

rvagg commented Apr 21, 2014

The current owner of the leveldb package in npm has agreed to let us take it over, we just need to figure out what we want to put there: my8bird/node-leveldb#52. Note that the current leveldb package isn't very happy with newer releases of Node, and certainly not 0.11 which is a major pain for any native addon to support.

The only caveat is that we just bump the major version so the existing code can be left intact.

Some (non-exhaustive) options:

  • Publish the current level package as leveldb
  • Publish leveldown as leveldb
  • Create something new that wraps leveldown to make something that behaves closer to the LevelDB API (I'm not sure what this would look like, LevelDOWN probably is that thing already)

Thoughts?

One additional thought from me is that as far as I know, what the current leveldb package does that we don't support is:

  • Explicit snapshots
  • Synchronous operations

While I'm not particularly in favour of adding the latter, I think we really should get to work on getting snapshotting in, it's the big missing thing and while it's not something we have people begging for, it might open up some interesting new experiments!

@dominictarr
Copy link
Contributor

and seek on iterators - we have munged it into one directional streams.

@mcollina
Copy link
Member

👍 for releasing leveldown as leveldb.
👎 for sync operations.

@huan
Copy link
Contributor

huan commented Aug 22, 2018

Today I run into this issue in sudden because I'm wondering about who is using the leveldb npm name.

It would be really nice to rename leveldown to leveldb because it will be a clearer name and prevent confusing new comers who want to use leveldb.

@vweevers
Copy link
Member

That can cause confusion too. The main package for newcomers is level, rather than leveldown by itself.

I like the current symmetry with other *downs. Instead of renaming, there's always room for improvement in the documentation, to explain the concept of up + down = level and to point people in the right direction.

And in general, unless there's a legal reason, I strongly dislike renaming a package with this age. It cuts the historical record in half.

@ralphtheninja ralphtheninja reopened this Dec 18, 2018
@ralphtheninja ralphtheninja transferred this issue from Level/levelup Dec 18, 2018
@vweevers vweevers added the discussion Discussion label Jan 1, 2019
@vweevers
Copy link
Member

For the considerable future, the answer to "What to do with the 'leveldb' package" is "nothing".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion
Projects
None yet
Development

No branches or pull requests

6 participants