Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gitignore and npmignore #101

Merged
merged 2 commits into from
Apr 8, 2019
Merged

Update gitignore and npmignore #101

merged 2 commits into from
Apr 8, 2019

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Apr 7, 2019

Closes #88, taking into account that we'll move Snappy to a git submodule later (which will change its path). I've verified on Windows that building still works (from npm pack).

Removes the following files from the npm tarball:

Click to expand 
11,47d10
< deps/leveldb/leveldb-rocksdb/.arcconfig
< deps/leveldb/leveldb-rocksdb/.clang-format
< deps/leveldb/leveldb-rocksdb/arcanist_util/__phutil_library_init__.php
< deps/leveldb/leveldb-rocksdb/arcanist_util/__phutil_library_map__.php
< deps/leveldb/leveldb-rocksdb/arcanist_util/config/FacebookArcanistConfiguration.php
< deps/leveldb/leveldb-rocksdb/arcanist_util/config/FacebookOldArcanistConfiguration.php
< deps/leveldb/leveldb-rocksdb/arcanist_util/config/RocksDBCommonHelper.php
< deps/leveldb/leveldb-rocksdb/arcanist_util/cpp_linter/ArcanistCpplintLinter.php
< deps/leveldb/leveldb-rocksdb/arcanist_util/cpp_linter/BaseDirectoryScopedFormatLinter.php
< deps/leveldb/leveldb-rocksdb/arcanist_util/cpp_linter/cpplint.py
< deps/leveldb/leveldb-rocksdb/arcanist_util/cpp_linter/FacebookHowtoevenLinter.php
< deps/leveldb/leveldb-rocksdb/arcanist_util/cpp_linter/FbcodeClangFormatLinter.php
< deps/leveldb/leveldb-rocksdb/arcanist_util/cpp_linter/FbcodeCppLinter.php
< deps/leveldb/leveldb-rocksdb/arcanist_util/lint_engine/FacebookFbcodeLintEngine.php
< deps/leveldb/leveldb-rocksdb/arcanist_util/lint_engine/FacebookHowtoevenLintEngine.php
< deps/leveldb/leveldb-rocksdb/arcanist_util/unit_engine/FacebookFbcodeUnitTestEngine.php
< deps/leveldb/leveldb-rocksdb/arcanist_util/unit_engine/FacebookOldFbcodeUnitTestEngine.php
< deps/leveldb/leveldb-rocksdb/build_tools/amalgamate.py
< deps/leveldb/leveldb-rocksdb/build_tools/build_detect_platform
< deps/leveldb/leveldb-rocksdb/build_tools/cont_integration.sh
< deps/leveldb/leveldb-rocksdb/build_tools/dependencies_4.8.1.sh
< deps/leveldb/leveldb-rocksdb/build_tools/dependencies.sh
< deps/leveldb/leveldb-rocksdb/build_tools/dockerbuild.sh
< deps/leveldb/leveldb-rocksdb/build_tools/error_filter.py
< deps/leveldb/leveldb-rocksdb/build_tools/fb_compile_mongo.sh
< deps/leveldb/leveldb-rocksdb/build_tools/fbcode_config.sh
< deps/leveldb/leveldb-rocksdb/build_tools/fbcode_config4.8.1.sh
< deps/leveldb/leveldb-rocksdb/build_tools/format-diff.sh
< deps/leveldb/leveldb-rocksdb/build_tools/gnu_parallel
< deps/leveldb/leveldb-rocksdb/build_tools/make_new_version.sh
< deps/leveldb/leveldb-rocksdb/build_tools/make_package.sh
< deps/leveldb/leveldb-rocksdb/build_tools/precommit_checker.py
< deps/leveldb/leveldb-rocksdb/build_tools/regression_build_test.sh
< deps/leveldb/leveldb-rocksdb/build_tools/rocksdb-lego-determinator
< deps/leveldb/leveldb-rocksdb/build_tools/run_ci_db_test.ps1
< deps/leveldb/leveldb-rocksdb/build_tools/update_dependencies.sh
< deps/leveldb/leveldb-rocksdb/build_tools/version.sh
49,51d11
< deps/leveldb/leveldb-rocksdb/CONTRIBUTING.md
< deps/leveldb/leveldb-rocksdb/coverage/coverage_test.sh
< deps/leveldb/leveldb-rocksdb/coverage/parse_gcov_output.py
218,230d177
< deps/leveldb/leveldb-rocksdb/DEFAULT_OPTIONS_HISTORY.md
< deps/leveldb/leveldb-rocksdb/DUMP_FORMAT.md
< deps/leveldb/leveldb-rocksdb/examples/c_simple_example.c
< deps/leveldb/leveldb-rocksdb/examples/column_families_example.cc
< deps/leveldb/leveldb-rocksdb/examples/compact_files_example.cc
< deps/leveldb/leveldb-rocksdb/examples/compaction_filter_example.cc
< deps/leveldb/leveldb-rocksdb/examples/Makefile
< deps/leveldb/leveldb-rocksdb/examples/optimistic_transaction_example.cc
< deps/leveldb/leveldb-rocksdb/examples/options_file_example.cc
< deps/leveldb/leveldb-rocksdb/examples/README.md
< deps/leveldb/leveldb-rocksdb/examples/rocksdb_option_file_example.ini
< deps/leveldb/leveldb-rocksdb/examples/simple_example.cc
< deps/leveldb/leveldb-rocksdb/examples/transaction_example.cc
233d179
< deps/leveldb/leveldb-rocksdb/hdfs/setup.sh
313,314d258
< deps/leveldb/leveldb-rocksdb/INSTALL.md
< deps/leveldb/leveldb-rocksdb/LANGUAGE-BINDINGS.md
353d296
< deps/leveldb/leveldb-rocksdb/ROCKSDB_LITE.md
433d375
< deps/leveldb/leveldb-rocksdb/third-party/fbson/COMMIT.md
439,441d380
< deps/leveldb/leveldb-rocksdb/third-party/gtest-1.7.0/fused-src/gtest/CMakeLists.txt
< deps/leveldb/leveldb-rocksdb/third-party/gtest-1.7.0/fused-src/gtest/gtest-all.cc
< deps/leveldb/leveldb-rocksdb/third-party/gtest-1.7.0/fused-src/gtest/gtest.h
443,446d381
< deps/leveldb/leveldb-rocksdb/tools/auto_sanity_test.sh
< deps/leveldb/leveldb-rocksdb/tools/benchmark_leveldb.sh
< deps/leveldb/leveldb-rocksdb/tools/benchmark.sh
< deps/leveldb/leveldb-rocksdb/tools/check_format_compatible.sh
451d385
< deps/leveldb/leveldb-rocksdb/tools/db_crashtest.py
459d392
< deps/leveldb/leveldb-rocksdb/tools/generate_random_db.sh
463d395
< deps/leveldb/leveldb-rocksdb/tools/ldb_test.py
467,474d398
< deps/leveldb/leveldb-rocksdb/tools/rdb/API.md
< deps/leveldb/leveldb-rocksdb/tools/rdb/binding.gyp
< deps/leveldb/leveldb-rocksdb/tools/rdb/db_wrapper.cc
< deps/leveldb/leveldb-rocksdb/tools/rdb/db_wrapper.h
< deps/leveldb/leveldb-rocksdb/tools/rdb/rdb
< deps/leveldb/leveldb-rocksdb/tools/rdb/rdb.cc
< deps/leveldb/leveldb-rocksdb/tools/rdb/README.md
< deps/leveldb/leveldb-rocksdb/tools/rdb/unit_test.js
476,480d399
< deps/leveldb/leveldb-rocksdb/tools/regression_test.sh
< deps/leveldb/leveldb-rocksdb/tools/rocksdb_dump_test.sh
< deps/leveldb/leveldb-rocksdb/tools/run_flash_bench.sh
< deps/leveldb/leveldb-rocksdb/tools/run_leveldb.sh
< deps/leveldb/leveldb-rocksdb/tools/sample-dump.dmp
485,486d403
< deps/leveldb/leveldb-rocksdb/tools/verify_random_db.sh
< deps/leveldb/leveldb-rocksdb/tools/write_stress_runner.py
488d404
< deps/leveldb/leveldb-rocksdb/USERS.md
666d581
< deps/leveldb/leveldb-rocksdb/utilities/env_librados.md
751,752d665
< deps/leveldb/leveldb-rocksdb/Vagrantfile
< deps/leveldb/leveldb-rocksdb/WINDOWS_PORT.md
754,757d666
< deps/leveldb/leveldb.sln
< deps/leveldb/leveldb.vcxproj
< deps/leveldb/leveldb.vcxproj.filters
< deps/leveldb/Release/*
766,767d674
< deps/snappy/Release/*
< deps/snappy/snappy-1.1.7/.appveyor.yml
770,771d676
< deps/snappy/snappy-1.1.7/CMakeLists.txt
< deps/snappy/snappy-1.1.7/CONTRIBUTING.md
773,774d677
< deps/snappy/snappy-1.1.7/format_description.txt
< deps/snappy/snappy-1.1.7/framing_format.txt
790,792d692
< deps/snappy/snappy.sln
< deps/snappy/snappy.vcxproj
< deps/snappy/snappy.vcxproj.filters

@vweevers vweevers added the cleanup Housekeeping label Apr 7, 2019
@vweevers vweevers added this to In progress in Level (old board) via automation Apr 7, 2019
@vweevers vweevers moved this from In progress to Review in Level (old board) Apr 7, 2019
@vweevers vweevers mentioned this pull request Apr 7, 2019
Merged
@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Apr 7, 2019
@vweevers
Copy link
Member Author

vweevers commented Apr 7, 2019 •
edited

Canceling a few rocksdb builds because AppVeyor is too busy to make prebuilds for leveldown@5.0.1.

And @filoozom there was a secondary GitHub webhook to your AppVeyor account; I've disabled it.

@filoozom
Copy link
Contributor

filoozom commented Apr 8, 2019

@vweevers Ah thank you, must have messed that up when I was trying to re-run a failed build.

@vweevers vweevers merged commit 7ca6de7 into master Apr 8, 2019
Level (old board) automation moved this from Review to Done Apr 8, 2019
@vweevers vweevers deleted the ignore branch April 8, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralphtheninja ralphtheninja ralphtheninja approved these changes

@filoozom filoozom filoozom approved these changes

Assignees
No one assigned
Labels
cleanup Housekeeping semver-patch Bug fixes that are backward compatible
Projects
No open projects
Level (old board)
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vweevers @filoozom @ralphtheninja