Merge pull request #40 from level12/upload-link-perms

Fix Azure blob SAS URL permissions
level12 · Apr 28, 2020 · d7a1653 · d7a1653
2 parents 52eda5a + 7f83ffe
commit d7a1653
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/keg_storage/backends/azure.py b/keg_storage/backends/azure.py
@@ -285,7 +285,7 @@ def create_upload_url(self, path: str, expire: typing.Union[arrow.Arrow, datetim
         """
         return self._create_sas_url(
             path=path,
-            sas_permissions='c',
+            sas_permissions='cw',
             expire=expire,
             ip=ip,
         )

diff --git a/keg_storage/tests/test_backend_azure.py b/keg_storage/tests/test_backend_azure.py
@@ -271,7 +271,7 @@ def test_upload_url(self, expire: Union[arrow.Arrow, datetime.datetime]):
         qs = urlparse.parse_qs(parsed.query)
 
         assert qs['se'] == ['2019-01-02T03:04:05Z']
-        assert qs['sp'] == ['c']
+        assert qs['sp'] == ['cw']
         assert qs['sig']
         assert 'sip' not in qs
 
@@ -287,7 +287,7 @@ def test_upload_url(self, expire: Union[arrow.Arrow, datetime.datetime]):
         qs = urlparse.parse_qs(parsed.query)
 
         assert qs['se'] == ['2019-01-02T03:04:05Z']
-        assert qs['sp'] == ['c']
+        assert qs['sp'] == ['cw']
         assert qs['sig']
         assert qs['sip'] == ['127.0.0.1']