Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My positions doesn't work if not connected #108

Closed
bingen opened this issue May 9, 2019 · 4 comments
Closed

My positions doesn't work if not connected #108

bingen opened this issue May 9, 2019 · 4 comments

Comments

@bingen
Copy link
Contributor

bingen commented May 9, 2019

It makes sense, as the app doesn't know the address, but it would be nice to have an error message. Right now it's just a blank screen:

Screenshot from 2019-05-09 09-47-11

@ewilz
Copy link
Contributor

ewilz commented May 10, 2019

we were hoping to take this a step further and notify the user whenever they're logged into a separate network than the Dapp. Is this possible within an aragon app to check the network of metamask?

@sohkai
Copy link

sohkai commented May 11, 2019

Seeing as you're on using @aragon/api@1.1.0, yes, this is available.

- Get the network: app.network()
- This is an observable but really will only ever emit one value for now

  • Get the connected accounts: app.accounts()
    • This will emit every time the user changes their account

Ahh, actually there is no way to get the user's connected network, only the network the client is connected to (aragon/aragon.js#300)

@ewilz
Copy link
Contributor

ewilz commented May 11, 2019

#118

@ewilz
Copy link
Contributor

ewilz commented May 14, 2019

Fixed in #118

@ewilz ewilz closed this as completed May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants