Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong validation in "Slippage tolerance" field in settings #523

Closed
kingalg opened this issue Dec 17, 2021 · 2 comments
Closed

Wrong validation in "Slippage tolerance" field in settings #523

kingalg opened this issue Dec 17, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@kingalg
Copy link

kingalg commented Dec 17, 2021

Path: Settings -> Slippage tolerance -> last field

Screenshot 2021-12-17 at 12.28.53.png

Validation seams to be broken - there is that warning sign sometimes (also it's not clarified what does it means exactly - it still let the user to use this percentage even with a warning).

The user can also choose negative number (he definitely shouldn't be), however if he does and try to use "swap" (by choosing two and entering amount) he will crash the app. We should block possibility of entering some amounts.

Screenshot 2021-12-17 at 12.46.35.png
Screenshot 2021-12-17 at 12.49.28.png

The last small thing about this area is how it looks like - last field should be visually different from the others as it let the user to do a different action (write something, not only choose).

@denciu denciu added the bug Something isn't working label Dec 17, 2021
@0xVenky
Copy link
Member

0xVenky commented Mar 29, 2022

We can close this one right? @kingalg Remember this was fixed as part of a differnt issue

@MilanVojnovic95
Copy link
Collaborator

@0xVenky
Tested and bugs from this issue are fixed so I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants