Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check if pr got 'ready-for-tests' label to save test results capacity #1451

Merged
merged 41 commits into from Sep 12, 2022

Conversation

niemam29
Copy link
Contributor

@niemam29 niemam29 commented Sep 9, 2022

As we already used 3/4 of test results capacity i changed a bit the way of executing tests, right now, unless there is no label 'ready-for-tests' label on pr the cypress smoke tests will not be executed.

cach2

This is temporary solution as i am researching possibility to switch to sorry-cypress

@netlify
Copy link

netlify bot commented Sep 9, 2022

Deploy Preview for swapr ready!

Name Link
🔨 Latest commit d4eb7cd
🔍 Latest deploy log https://app.netlify.com/sites/swapr/deploys/631efc6659e0d900080f7d46
😎 Deploy Preview https://deploy-preview-1451--swapr.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@mix1o mix1o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@github-actions github-actions bot temporarily deployed to check-if-pr-is-approved-in-ci September 9, 2022 11:48 Destroyed
@niemam29 niemam29 changed the title Added check if pr is approved to save test results capacity Added check if pr is approved to save test results capacity [WIP] [DO NOT REVIEW] Sep 9, 2022
@github-actions github-actions bot temporarily deployed to check-if-pr-is-approved-in-ci September 9, 2022 13:45 Destroyed
@github-actions github-actions bot temporarily deployed to check-if-pr-is-approved-in-ci September 9, 2022 14:03 Destroyed
@niemam29 niemam29 changed the title Added check if pr is approved to save test results capacity [WIP] [DO NOT REVIEW] Added check if pr got 'ready-for-tests' label to save test results capacity Sep 9, 2022
@wixzi
Copy link
Contributor

wixzi commented Sep 10, 2022

@niemam29 Nice idea to check labels and run cypress. 🍠

Do you still want to dump the Github context. Did you just done for debugging?
Also can't we add a label and rerun the action instead of creating a commit each time for Synpress?.

If possible I suggest you do a label check for synpress also. And then rerun the action in the actions page instead of creating an empty commit in each PR.

I am ok to merge this If you think its urgent to limit the cypress runs. But please check the options above if possible.

@wixzi
Copy link
Contributor

wixzi commented Sep 10, 2022


# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:

@github-actions github-actions bot temporarily deployed to check-if-pr-is-approved-in-ci September 12, 2022 08:57 Destroyed
@github-actions github-actions bot temporarily deployed to check-if-pr-is-approved-in-ci September 12, 2022 09:19 Destroyed
@github-actions github-actions bot temporarily deployed to check-if-pr-is-approved-in-ci September 12, 2022 09:41 Destroyed
@github-actions github-actions bot temporarily deployed to check-if-pr-is-approved-in-ci September 12, 2022 09:58 Destroyed
@niemam29
Copy link
Contributor Author


# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:

I will exclude tests back to CT pipe and then create a whole test runner using this dispatch

@niemam29 niemam29 merged commit 5af310e into develop Sep 12, 2022
@adamazad adamazad deleted the check-if-pr-is-approved-in-ci branch November 29, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants