Removed trades sorting and trade types functions from App and moved it to sdk #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for swapr ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Tested and noticed difference was in the values of min. received between the results on the eco router results and the official dex website...
Sushiswap Uniswap |
@MilanVojnovic95 Can you give steps to reproduce it...I can't trigger that behaviour for me it works. Thats very weird since its accurately inaccurate by 200$.... |
berteotti
approved these changes
Dec 2, 2022
MilanVojnovic95
approved these changes
Jan 29, 2023
berteotti
force-pushed
the
develop
branch
2 times, most recently
from
fb69230
to
0c5053c
Compare
berteotti
force-pushed
the
develop
branch
2 times, most recently
from
ff47650
to
b3b3815
Compare
berteotti
force-pushed
the
develop
branch
2 times, most recently
from
91e4f23
to
af06da1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is linked to sdk pr SwaprHQ/swapr-sdk#221