Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absurd values for real and imaginary parts of impedance in the output file #2

Open
r-mouta opened this issue May 8, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@r-mouta
Copy link

r-mouta commented May 8, 2020

The values of Z' and Z'' in the output file don't match those in the input csv file. In fact, they don't match any data from there. This occurred for an input file that contained simultaneously Z', Z'', |Z| and theta, a possibility that wasn't foreseen. The reason is the code automatically tries to convert |Z| and theta into Z' and Z'' if it finds 'Impedance Magnitude (Ohms)' in the 4th headline. But, since Z' and Z'' were also present, the code has mistaken them for |Z| and theta. As a result, absurd values are output.

To fix this bug, the code should make sure that Z' and Z'' aren't already in the input before trying to obtain them from |Z| and theta. This can be checked in the 4th headline of the input.

@r-mouta r-mouta added the bug Something isn't working label May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants