Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need docs to claim that all timeouts will not change during sessions #20

Open
defia opened this issue Feb 14, 2016 · 1 comment
Open
Milestone

Comments

@defia
Copy link

defia commented Feb 14, 2016

some options in request options, such as all timeout settings, is actually bind to http.Client.
in doRegularRequest, we create client each time if timeout is not zero.
but in doSessionRequest, the client is created in NewSession().
so if user pass a RequestOptions with timeout to session.Get(), it will not change client's timeout.

I think current timeout implementation is good,but it's better to add some docs about this behavior.

@defia defia changed the title Need docs to claim that all timeouts cannot changed during sessions Need docs to claim that all timeouts cannot be changed during sessions Feb 14, 2016
@defia defia changed the title Need docs to claim that all timeouts cannot be changed during sessions Need docs to claim that all timeouts will not change during sessions Feb 14, 2016
@levigross levigross added this to the 1.0 milestone Mar 1, 2016
@ghost
Copy link

ghost commented Jul 17, 2018

  1. connet timeout
  2. read response data timeout.
  3. timeout must be a range int

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants