You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
some options in request options, such as all timeout settings, is actually bind to http.Client.
in doRegularRequest, we create client each time if timeout is not zero.
but in doSessionRequest, the client is created in NewSession().
so if user pass a RequestOptions with timeout to session.Get(), it will not change client's timeout.
I think current timeout implementation is good,but it's better to add some docs about this behavior.
The text was updated successfully, but these errors were encountered:
defia
changed the title
Need docs to claim that all timeouts cannot changed during sessions
Need docs to claim that all timeouts cannot be changed during sessions
Feb 14, 2016
defia
changed the title
Need docs to claim that all timeouts cannot be changed during sessions
Need docs to claim that all timeouts will not change during sessions
Feb 14, 2016
some options in request options, such as all timeout settings, is actually bind to http.Client.
in doRegularRequest, we create client each time if timeout is not zero.
but in doSessionRequest, the client is created in NewSession().
so if user pass a RequestOptions with timeout to session.Get(), it will not change client's timeout.
I think current timeout implementation is good,but it's better to add some docs about this behavior.
The text was updated successfully, but these errors were encountered: