error handling

[astropanic]

Is there a reason why this library doesn't provide the "go way" of error handling ?

resp := grequests.Get("http://httpbin.org/xml", nil)

if resp.Error != nil {
    log.Fatalln("Unable to make request", resp.Error)
}

VS

resp, err := grequests.Get("http://httpbin.org/xml", nil)

if err != nil {
    log.Fatalln("Unable to make request", err)
}

[ShawnMilo]

The standard library uses both methods. The second is more common, but Scanner.Scan() in the bufio package does it the first way.

You read each line in the file, and at the end you check if your scanner's .Err is something you care about.

[levigross]

The resp.Error pattern is a remnant of the asynchronous nature of the library (up until a few days ago all functions returned a channel).

I do intend to make to change the API to the more "standard" way

resp, err := grequests.Get("http://httpbin.org/xml", nil)

if err != nil {
    log.Fatalln("Unable to make request", err)
}

[levigross]

Fixed in #0.2