Send proper server parameters to clients using admin db #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdrsh
commented
Jul 31, 2022
src/client.rs
Outdated
| @@ -313,8 +313,10 @@ where | |||
|
|
|||
| let mut target_pool: ConnectionPool = ConnectionPool::default(); | |||
| let mut transaction_mode = false; | |||
| let mut server_info = BytesMut::default(); | |||
There was a problem hiding this comment.
I get a warning here because BytesMut::default() value was overwritten before it was used.
Open for ideas on how to refactor this to avoid the warning.
There was a problem hiding this comment.
You can make if blocks return values, e.g.
let value = if true {
5
}
else
{
6
}so you don't have to have a default value up one scope level like in C/C++.
levkk
approved these changes
Jul 31, 2022
src/messages.rs
Outdated
|
|
||
| pub fn server_paramater_message(key: &str, value: &str) -> Result<BytesMut, Error> { | ||
| let mut server_info = BytesMut::new(); | ||
| if !key.is_ascii() || !value.is_ascii() || key.is_empty() { |
There was a problem hiding this comment.
You're generating these manually so you don't need this check.
jmeagher
pushed a commit
to jmeagher/pgcat
that referenced
this pull request
Feb 17, 2023
* Send proper server parameters to clients using admin db * clean up * fix python test * build * Add python * missing & * debug ls * fix tests * fix tests * fix * Fix warning * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Psycopg2 threw an error at connect-time when connecting to admin db, probably because we send no
Smessage back for that db (server_info is empty).The error it produced looks like this
This is easily reproducible so I added a test for it and enabled python tests.
This PR generates such message on-the-fly for admin db (I think this cleaner than just grabbing a
server_infostruct from any pool.