Add pool name and username to address object #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdrsh
commented
Aug 17, 2022
| @@ -84,11 +89,11 @@ impl Address { | |||
| /// Address name (aka database) used in `SHOW STATS`, `SHOW DATABASES`, and `SHOW POOLS`. | |||
| pub fn name(&self) -> String { | |||
| match self.role { | |||
| Role::Primary => format!("{}_shard_{}_primary", self.database, self.shard), | |||
| Role::Primary => format!("{}_shard_{}_primary", self.poolname, self.shard), | |||
There was a problem hiding this comment.
self.database will now point to the actual database name on Postgres and not the pool name, so we have to change the names used here
drdrsh
commented
Aug 17, 2022
| @@ -114,12 +114,14 @@ impl ConnectionPool { | |||
|
|
|||
| let address = Address { | |||
| id: address_id, | |||
| database: pool_name.clone(), | |||
| database: shard.database.clone(), | |||
There was a problem hiding this comment.
I think this was an oversight in the initial multi-db PR. database should point to the actual database name and not the pool name
jmeagher
added a commit
to jmeagher/pgcat
that referenced
this pull request
Feb 17, 2023
…re-config-generator Catalog store config generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pool name and Username are used as identifiers for individual pools in Pgcat. This data is very difficult to extract from individual
Addressobjects. We need to extract that information to make logs and (in the future, metrics) more useful. Currently banning log messages looks likeIt would be great if we get information about the pool name and username for the pool this address came from.