Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaults for configs #174

Merged
merged 3 commits into from
Sep 23, 2022

Conversation

zainkabani
Copy link
Contributor

@zainkabani zainkabani commented Sep 23, 2022

Currently every config value has to be set in the toml file. We can reduce the amount of effort required to generate this file by setting defaults

A follow up PR will be required to add documentation about default values

@zainkabani zainkabani marked this pull request as draft September 23, 2022 05:00
@zainkabani zainkabani marked this pull request as ready for review September 23, 2022 05:05
Copy link
Collaborator

@levkk levkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@levkk levkk merged commit f72dac4 into postgresml:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants