Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2.1.99 #17

Closed
Templarian opened this issue Mar 9, 2018 · 5 comments
Closed

Update to 2.1.99 #17

Templarian opened this issue Mar 9, 2018 · 5 comments

Comments

@Templarian
Copy link

Awesome project, adding this to the list of projects I'll try to track after each release.

Might be a good idea to use mdi-svg as dependency instead of as a folder like some of the other libraries do (ember for instance I think does this).

@levrik
Copy link
Owner

levrik commented Mar 16, 2018

Since I'm not shipping the original SVG files with this library (transforming them into SVG components instead) I won't include mdi-svg as an dependency. At the moment I'm trying to come up with some new versioning since the current one doesn't work well. See #9 for more information. I'm open for feedback about that, especially since you're the creator of mdi.

@Templarian
Copy link
Author

Yea, that works. As long as there is an easy way for people to know what version of mdi is included the version can be anything. 😃

Sorry for the confusion I meant as a NPM dev dependency instead of the git submodule (didn't look at the scripts, but assuming it's extracting data from them).

@levrik
Copy link
Owner

levrik commented Mar 16, 2018

@Templarian Ah, got it. I think it doesn't matter if I include it via a submodule or npm. The published module is different from the one which needs to pull in mdi. (package.json on the top-level is never published, only the one in the publish folder.)

@levrik
Copy link
Owner

levrik commented Mar 16, 2018

Released in 3.0.0

@felixfbecker
Copy link
Contributor

I think it doesn't matter if I include it via a submodule or npm.

Here are the benefits I see:

  • npm info react-mdi@$VERSION devDependencies.mdi easily gives me the version of mdi a certain version of react-mdi was built from (which is more important now that the versioning is decoupled).
  • A green devDependencies up-to-date badge can highlight in the readme that it is built from the latest mdi
  • Greenkeeper/Renovate/... can do automatic PRs to update
  • CI can use the npm cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants