Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to mdi/svg 4.3.95 #65

Closed
smeijer opened this issue Sep 7, 2019 · 6 comments
Closed

Update to mdi/svg 4.3.95 #65

smeijer opened this issue Sep 7, 2019 · 6 comments

Comments

@smeijer
Copy link

smeijer commented Sep 7, 2019

@mdi is currently at 4.3.95, while the used version is 3.7.95. Can you bump it? I'm missing some icons in this package.

@smeijer smeijer changed the title Update to 4.3.95 Update to mdi/svg 4.3.95 Sep 7, 2019
@levrik
Copy link
Owner

levrik commented Sep 7, 2019

Hey @smeijer. I know. The process of updating is quite annoying at the moment. Since I got an invitation to the GitHub Actions beta I'm experimenting with them to automate this process just right now.
See https://github.com/levrik/mdi-react/commit/15bda53be25538daad054979feb0587c4d67dd21/checks for a first run of the simple build process.
I hope that this is finished by the end of this weekend so it can be used to keep the icons up to date from there on.

@levrik
Copy link
Owner

levrik commented Sep 7, 2019

4.3.95 is included with 6.0.0. The process is automated via GitHub Actions now so mdi updates should be on time in future.

@levrik levrik closed this as completed Sep 7, 2019
@smeijer
Copy link
Author

smeijer commented Sep 9, 2019

A little off-topic, but where you able to automate it based on activity in the mdi/svg repo? Or does it still require a manual action in this repo?

Thanks for the update!

@levrik
Copy link
Owner

levrik commented Sep 10, 2019

Some explanation of the previous process:

I set up the Renovate bot to issue PRs if @mdi/svg updates. That is still the same now. Before I had to manually merge, update the changelog and readme and publish (building takes about 4 minutes). Also I had to publish two packages since this repo also publishes a version for Preact. It's not a that crazy process but it took time which often was missing.

Now I automated the process after manually merging the PR by Renovate.
It updates the changelog and readme and builds and publishes both packages.
The coming weekend I'll go even further and will let the GitHub Action run if Renovate creates a PR. This will then also include the merging in the automated process.

@smeijer
Copy link
Author

smeijer commented Sep 10, 2019

Sounds very awesome! I never thought of using Renovate to trigger the GitHub actions. Thanks for sharing.

@levrik
Copy link
Owner

levrik commented Sep 10, 2019

If you're curious, here's the commit: 2ab666a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants