Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project-initiation #1

Merged
merged 6 commits into from Apr 18, 2022
Merged

Project-initiation #1

merged 6 commits into from Apr 18, 2022

Conversation

levy002
Copy link
Owner

@levy002 levy002 commented Apr 18, 2022

Description

In this PR, we initiated a Math magicians project.

General requirements

  • There are no linter errors.
  • Followed the Github flow.
  • The documentation is professional.

Milestone requirements, We:

  • created React application by using create-react-app.

Happy reviewing 馃槂

Copy link

@gemmen29 gemmen29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @levy002,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 馃帀

To Highlight 馃挴

  • No linters errors 鉁旓笍
  • Descriptive pull request 鉁旓笍
  • Descriptive commit messages 鉁旓笍

Optional suggestions

Cheers and Happy coding!馃憦馃憦馃憦

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@levy002
Copy link
Owner Author

levy002 commented Apr 18, 2022

Hi @levy002,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! tada

To Highlight

  • No linters errors heavy_check_mark
  • Descriptive pull request heavy_check_mark
  • Descriptive commit messages heavy_check_mark

Optional suggestions

Cheers and Happy coding!clapclapclap

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Thank you @gemmen29 馃

@levy002 levy002 merged commit 0686a8f into main Apr 18, 2022
@levy002 levy002 changed the title Project initiation Project-initiation Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants