Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying / untangling if-else commands in "Linking your default browser to Ubuntu" #305

Closed
lislis opened this issue Jul 2, 2021 · 1 comment · Fixed by #345
Closed
Assignees

Comments

@lislis
Copy link

lislis commented Jul 2, 2021

Some students seem a little confused with the if-else structure of the browser commands, probably because it's already programming lingo.
What they do is copy all the commands and end up with several export $BROWSER statements in their .zshrc and usually the the wrong one going last and overwriting the rest.
Maybe there is a way to formulate that they should either one or the other but definitely only run one?

@dmilon dmilon self-assigned this Oct 4, 2021
@dmilon
Copy link
Contributor

dmilon commented Oct 4, 2021

Hi @lislis 👋

There is definitely something to improve about how we define the BROWSER environment variable and how we persist it after the dotfiles repo fork & clone. I'm going to have a look into updating the install.sh ASAP.

Related to #303

@dmilon dmilon mentioned this issue Jan 6, 2022
13 tasks
@dmilon dmilon linked a pull request Jan 6, 2022 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants