-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The requested check was never run against this ref, exiting... #7
Comments
I get the same thing.... |
I solved this by running with |
Let me know if it worked! I think I have to get serious about it and start a Changelog and regular release shedule, will be on it right after the New Year! For now using |
hi @owen2345 — can you please send me the example code from your workflow that uses the |
Sure @progapandist
Please let me know if you need anything else to find the problem. |
Thank you! Try passing |
Maybe omitting check name for all checks doesn't work as expected. Can you try waiting for all three testing checks explicitly one after another and see if that works? |
Unfortunately it did not work (the same problem "it still stuck"). |
Unfortunately I don’t see an immediate answer. Try referring to wait-on-check-action@v0.1, do one test at a time, and pass check names explicitly. If it works, then it must be a regression in master but I have no time to investigate urgently. |
The problem seems to be that the workflow is waiting for itself to finish in order to continue. When the |
Yes, that means #6 probably messed it up. Sorry for the oversight. I will try to investigate, but haven’t got a lot of free time on my hands rn. If someone can see the problem clearly and make a quick PR - that will be much appreciated! |
For now the solution would be to wait on check name explicitly, don’t omit it, as @matiasalbarello mentioned (thanks!) |
Should be fixed thanks to #10 (🙌 @matiasalbarello), please check and confirm so I can close this issue |
I believe #10 introduced a new issue: |
Thanks for letting me know, will fix tonight |
bafe56a — this should fix it, please check @codetheweb 🙏 |
Looks like it's working now, thank you! Could you tag it too please so I can pin the version? |
Sure, will do it now, it's a long time coming... |
https://github.com/lewagon/wait-on-check-action/releases/tag/v0.2 🎉 big thanks to everyone involved! I will close the issue, feel free to reopen if any more corner cases surface |
Hello!
I am using your action to solve a problem I have:
So I set up a new workflow with your action, I used github.sha as ref because it runs in pushes to the PR.
on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
branches:
- master
name: Wait until build is complete
uses: lewagon/wait-on-check-action@v0.1
with:
ref: ${{ github.sha }} # can be commit SHA or tag too
check-name: build # name of the existing check - omit to wait for all checks
repo-token: ${{ secrets.GITHUB_TOKEN }}
wait-interval: 15 # seconds
I got this error. Maybe they triggered at the same time and e2e run before build job was started? I dont know if the correct way to implement it is to place some "sleep 15" before your wait on check 🤔
The requested check was never run against this ref, exiting...
Thank you for your time!
The text was updated successfully, but these errors were encountered: