Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow maximising the main window #58

Open
LewisGaul opened this issue Jan 19, 2020 · 2 comments
Open

Allow maximising the main window #58

LewisGaul opened this issue Jan 19, 2020 · 2 comments
Labels
enhancement New small feature/improvement
Milestone

Comments

@LewisGaul
Copy link
Owner

LewisGaul commented Jan 19, 2020

This is unintentionally possible when running through an x-server (XLaunch), but actually it can be nice to block everything else out.

This state should be persisted over restart.

Requested by Kyle

@LewisGaul LewisGaul added enhancement New small feature/improvement good-first-issue Newcomer-friendly issue labels Jan 19, 2020
@LewisGaul LewisGaul added this to the Release 4.0 milestone Jun 7, 2020
@LewisGaul LewisGaul changed the title Allow maximising window Allow maximising the main window Jun 7, 2020
This was referenced Jun 7, 2020
@LewisGaul
Copy link
Owner Author

LewisGaul commented Jun 28, 2020

This is kind of horrible to get working properly :)

  • Maximise button should be enabled (easy)
  • Default size should be the tight fit around the board (or with scrollbars if the board is bigger than the max window size)
  • When changing the board size (via dimensions or button size):
    • If the window is maximised it should stay maximised
    • If the window is not maximised and does not have any scrollbars it should be set to the default size
    • If the window is not maximised and has scrollbars it should be set to:
      • the tight fit around the board for dimensions where this is smaller than the current window size
      • unchanged for dimensions where the size is bigger or equal to the current window size
  • Ideally it would not be impossible to increase the window size beyond the tight fit. However, the naive approach prevents maximising the window [on Windows].
    • A less satisfactory alternative would be to reset to the default size when selecting the current difficulty (not including selecting a custom board of the same size), which can be done with a single keyboard button press (e.g. 'b').
  • Persist window state:
    • Whether maximised
    • The dimensions of the window (or displayed size of the minefield?)
  • The name bar should be strictly along the bottom, with padding being around the minefield frame such that the minefield is in the center of the space

@LewisGaul LewisGaul removed the good-first-issue Newcomer-friendly issue label Jun 28, 2020
@LewisGaul LewisGaul modified the milestones: Release 4.0, Release 4.1 Jun 28, 2020
@LewisGaul
Copy link
Owner Author

LewisGaul commented Jul 1, 2020

Enabled in beta options in PR #125, although buggy and state not persisted.

@LewisGaul LewisGaul added feature New feature (user-facing enhancement) and removed feature New feature (user-facing enhancement) labels Aug 19, 2021
@LewisGaul LewisGaul modified the milestones: Release 4.1, Release 4.2 Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New small feature/improvement
Projects
None yet
Development

No branches or pull requests

1 participant