Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light theme issue #26

Closed
Chirag-Galani opened this issue Sep 14, 2014 · 2 comments
Closed

Light theme issue #26

Chirag-Galani opened this issue Sep 14, 2014 · 2 comments

Comments

@Chirag-Galani
Copy link

Hey mate,
This is an awesome library. But, I am unable to do so although i commented mDarkTheme, passed false value in it.
Since, I am using eclipse had to copy your src files, style and other values in my project. All worked good except this Light theme issue. :(
Thanks for this lib. :) 👍

@StephaneBg
Copy link
Contributor

There is a bug in the CustomListDialog constructor. Call to super should be:

// Call super class constructor to create our dialog.
super(new ContextThemeWrapper(_builder.mContext, _builder.mIsDark ? R.style.Dark : R.style.Light));

@lewisjdeane
Copy link
Owner

Ah yes, my apologies will be updated when I get home, sorry about this.

lewisjdeane added a commit that referenced this issue Sep 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants