Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow template-haskell 2.17, 2.18 #34

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Conversation

sorki
Copy link
Contributor

@sorki sorki commented Aug 14, 2021

With a bit of CPP for backwards compatibility.

Ref https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.0#template-haskell-217

@jchia
Copy link

jchia commented Nov 11, 2021

I was just about to submit a PR, word-for-word the same as this one except for one type variable name.

@sorki I just did some tests and found that the template-haskell-2.18.0.0 also works so the upper bound can be bumped further:
- template-haskell >= 2.11 && < 2.19
This would allow freer-simple to work with the latest version of template-haskell.

@lexi-lambda Could you please process this PR and make a new hackage release if it looks good? It is needed for GHC 9.0.

@sorki sorki changed the title Allow template-haskell 2.17 Allow template-haskell 2.17, 2.18 Nov 13, 2021
@sorki
Copy link
Contributor Author

sorki commented Nov 13, 2021

I was just about to submit a PR, word-for-word the same as this one except for one type variable name.

@sorki I just did some tests and found that the template-haskell-2.18.0.0 also works so the upper bound can be bumped further: - template-haskell >= 2.11 && < 2.19 This would allow freer-simple to work with the latest version of template-haskell.

Nice! I've bumped the bound to allow 2.18 as well.

@lexi-lambda lexi-lambda merged commit 87403cc into lexi-lambda:master Jan 7, 2022
@lexi-lambda
Copy link
Owner

Thanks, and sorry about the delay.

@lexi-lambda
Copy link
Owner

I’ve now released this to Hackage as freer-simple-1.2.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants