Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some APIs could encode more finiteness information in their results #28

Open
countvajhula opened this issue Mar 29, 2022 · 0 comments
Open

Comments

@countvajhula
Copy link
Contributor

Some APIs do not return known-finite results even when such an inference could reliably be made. These in particular:

rest
take
drop
filter
map
reverse

In the seq library, these APIs are overridden with ones that annotate the result with finiteness information based on whether the input is known-finite or not. I did this purely for expediency as I was fleshing out the interfaces in that library, but it's very likely that these changes would be better incorporated upstream in data/collection, since otherwise, in order to use these libraries together, you need to:

(require (except-in data/collection rest take drop ...)
         seq)

instead of just

(require data/collection seq)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant