Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Condition $expression hint as string #305

Open
zajca opened this issue Feb 28, 2019 · 1 comment
Open

Condition $expression hint as string #305

zajca opened this issue Feb 28, 2019 · 1 comment

Comments

@zajca
Copy link

zajca commented Feb 28, 2019

In examples like https://github.com/lexik/LexikFormFilterBundle/blob/master/Resources/doc/working-with-the-bundle.md#ii-filter-customization user can see return $filterQuery->createCondition($expression, $parameters); where $expressing can be Composite but internally phpdoc hint is string. This will throw error in static analysis like Phpstan.
I suggests that this should be changed to mixed or in documentation should be $expression cast to string
return $filterQuery->createCondition((string)$expression, $parameters);

@FabienSalles
Copy link

Same problem here, I will disable the error on PHPStan but even my IDE complains.

Is there a reason to have a string type in this phpdoc ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants