Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic host/port config #16

Closed
pikeas opened this issue Jul 5, 2017 · 1 comment · Fixed by #20
Closed

Dynamic host/port config #16

pikeas opened this issue Jul 5, 2017 · 1 comment · Fixed by #20

Comments

@pikeas
Copy link

pikeas commented Jul 5, 2017

Currently, start_link/0 calls Fluxster.config_for/1. This seems to prevent runtime configuration of parameters.

Here are a few ways to improve this:

  • Add @defoverridable start_link: 0
  • Make Fluxster.config_for the default value for a new config_fun variable.
  • Have config_for read from System.get_env before Application.get_all_env.
  • Move config_for into __using__ and make it overridable, and call it on the module rather than on Fluxter.
@rosacris
Copy link

I've submitted a pull request to implement such functionality.
#19
Enjoy!

@lexmag lexmag mentioned this issue Oct 5, 2017
Merged
@lexmag lexmag closed this as completed in #20 Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce start_link/1 callback to support runtime configuration lexmag/fluxter
2 participants
@pikeas @rosacris