Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This is brilliant #3

Open
cseelus opened this issue Oct 8, 2018 · 4 comments
Open

This is brilliant #3

cseelus opened this issue Oct 8, 2018 · 4 comments

Comments

@cseelus
Copy link

cseelus commented Oct 8, 2018

Thanks!

Does only work with older Rails projects (<= 3.0 though) because of before_filter.

Is there a reason this isn't maintained anymore/would a PR be accepted?
@razvan-sv
Copy link
Contributor

Hello,

before_filter is available in all Rails versions. What's the issue?

@cseelus
Copy link
Author

cseelus commented Oct 8, 2018

before_filter is deprecated in favor of before_action afaik since 3.0 and removed with 5.1 or earlier.

A Rails 5.2 test app I tried this gem with throws undefined method 'before_filter' for ApplicationController:Class Did you mean? before_action.

@jrust
Copy link
Contributor

jrust commented Oct 8, 2018

A PR would be accepted; even better is if someone would like to take ownership of the project as I no longer have time to maintain it 😃

@softbrada
Copy link
Contributor

this was fixed in #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jrust @razvan-sv @cseelus @softbrada