fix(tiny_fd): assert disconnection on (re-)connection request of a co… #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnected peer This may happen for example if the peer was reset and right after boot it sends the SABM or SNRM frame. If the startup time of the peer is short (in the worst case it is enough that the startup time is less than the keep-alive timeout), it is possible that the primary has not detected the disconnection of peer yet.
|
I'm sorry for so very long delay. |
|
Thanks for the reply. Honestly, I think I should have included some unit tests, but the existing testing fixtures are rather unfamiliar to me. If you are so kind to test and validate this patch, that would be awesome! Alternatively, I'll take some time to add the tests, but I can't promise anything in terms of time. |
|
BTW
Seems reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may happen for example if the peer was reset and right after boot it sends the SABM or SNRM frame. If the startup time of the peer is short (in the worst case it is enough that the startup time is less than the keep-alive timeout), it is possible that the primary has not detected the disconnection of peer yet.
Fixes #36